Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add internal/db/rdb/mysql/option test #626

Merged
merged 5 commits into from
Aug 14, 2020
Merged

add internal/db/rdb/mysql/option test #626

merged 5 commits into from
Aug 14, 2020

Conversation

vankichi
Copy link
Contributor

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

  • create test for internal/db/rdb/mysql/option
  • update comment for each function in internal/db/rdb/mysql/option

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi vankichi self-assigned this Aug 13, 2020
@pull-assistant
Copy link

pull-assistant bot commented Aug 13, 2020 •
edited
Loading

Score: 0.99

Best reviewed: commit by commit

Optimal code review plan

     ✅ add internal/db/rdb/mysql/option test

     Update internal/db/rdb/mysql/option_test.go

     Update internal/db/rdb/mysql/option_test.go

     Update internal/db/rdb/mysql/option_test.go

     🤖 Update license headers / Format go codes and yaml files

Powered by Pull Assistant. Last update 28dbaa8 ... 0999765. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@codecov
Copy link

codecov bot commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #626 into master will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   13.77%   14.16%   +0.39%     
==========================================
  Files         408      408              
  Lines       21456    21456              
==========================================
+ Hits         2955     3040      +85     
+ Misses      18226    18144      -82     
+ Partials      275      272       -3
Impacted Files Coverage Δ
internal/db/rdb/mysql/option.go 100.00% <ø> (+95.34%) ⬆️
internal/worker/worker.go 86.36% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca45ea...0999765. Read the comment docs.

kevindiu
kevindiu previously approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 previously approved these changes Aug 13, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/db/rdb-mysql-option

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@vdaas-ci vdaas-ci dismissed stale reviews from hlts2 and kevindiu via edeac98 August 13, 2020 09:46
vdaas-ci
vdaas-ci previously approved these changes Aug 13, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@rinx rinx mentioned this pull request Aug 13, 2020
Merged
18 tasks
@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/db/rdb-mysql-option

vankichi and others added 3 commits August 14, 2020 01:31
@vankichi @actions-user
✅ add internal/db/rdb/mysql/option test
28dbaa8 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @kevindiu @actions-user
Update internal/db/rdb/mysql/option_test.go
56b7668 
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
@vankichi @kevindiu @actions-user
Update internal/db/rdb/mysql/option_test.go
abe0d31 
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
vankichi and others added 2 commits August 14, 2020 01:31
@vankichi @kevindiu @actions-user
Update internal/db/rdb/mysql/option_test.go
b5dc446 
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
@vdaas-ci @actions-user
🤖 Update license headers / Format go codes and yaml files
0999765 
Signed-off-by: vdaas-ci <ci@vdaas.org>
@vdaas-ci vdaas-ci force-pushed the test/internal/db/rdb-mysql-option branch from edeac98 to 0999765 Compare August 14, 2020 01:31
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 00645e1 into master Aug 14, 2020
@vankichi vankichi deleted the test/internal/db/rdb-mysql-option branch August 14, 2020 02:20
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@hlts2 hlts2 hlts2 left review comments

@kevindiu kevindiu kevindiu left review comments

Assignees

@vankichi vankichi

Labels
area/internal priority/low size/XXL team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kevindiu @hlts2